[ML] Fix invalid writes and increase robustness #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily fixes two potential edge cases leading to invalid writes:
shiftTimefor the expanding window was after the start of the window. This led to unsigned integer underflow and bad arguments supplied tostd::fill. This could very occasionally happen.As part of tracking down these memory corruptions, I also audited potentially dangerous places in the code. These were safe, but relied on rather delicate invariants or inputs being correct. I've tightened up the logic to ensure that these assumptions are now checked.
This is unreleased code so marking as a non-issue.